Code Review Process with Bamboo Crucible and Stash

[JL]

We want to implement code reviews at our company, but are not quite sure how the process would work. We currently use JIRA / Fisheye, Jenkins and svn, but would like to switch to Git.

We were considering using Bamboo (instead of Jenkins), Stash, Crucible, and (possibly) Clover and Greenhopper. Do these products work together well? We're most concerned about Stash, Crucible, and Bamboo getting along.

Our basic idea would be to basically input a build (& test) + review before the automatic Stash merge. Is this possible to do? Are we approaching this the wrong way?

Thanks!

[James Dumay · Accepted solution]

You are certainly approaching this the right way :)

Bamboo detects new branches, creates builds for each branch, merges changes from master into the current branch and runs the tests against the result (you can optionally push back to master if the tests pass). Take a read of this blog that shows you how to get it all working.

[JL]

Is it possible to do a code review in the middle of there though? That's where we're a bit stuck...nothing seems to mention integration with Crucible.

[Jens Schumacher [Atlassian]]

If you are using Stash, you can use Pull Requests to do the code review. Take a look at our release notes for more details.

https://confluence.atlassian.com/display/STASH/Stash+1.3+release+notes

The Stash team uses story branches and creates Pull Requests for reviewes. Although builds are run, they are currently not integrated into Stash. We will post a more detailed blog post about our own development process in the coming week.

[Semyon Vadishev]

My reply isn't strictly relevant to the question, so I put it as a comment here.

As you are switching from Subversion to Git, consider using SVN Importer Plugin for Stash to migrate the project's history. The plugin is Free; it's built upon SubGit, so it has the highest fidelity of translation among all the converters available. For more details refer to the official site or contact us at support@subgit.com.