Amended commits trashes pull request's comments

[Erik L]

I had a commit that I wanted changed and did a amend git and force pushed that up. But when I went back to the pull request, the comments that were on that are now gone. Is this intended?

[ThomasA · Accepted solution]

Hi Erik,

Did you just alter the commit message or the actual contents?

Updates to a file in a pull request can cause comments to disappear. We attempt to put the comments back on the correct line however this is not always possible for example when the line is removed from the file.

It is not possible for me to comment on whether this particular comment should have been drifted or not as I don't know the particulars.

The bitbucket team wrote a detailed description (see the "High Plains Drifter" section) of how they implemented comment drift which may help you understand how this issue is approached.

Lastly I am not clear is this a bitbucket pull request or a Stash pull request?

Regards,

Tom

[Ramon Gonzalez]

This is still a problem. As a general rule comments should not disappear in any case. If a line number is no longer relevant, then the comments must be attached to the file, without line context. 

PR comments are live discussions until declared closed by user. 

The current behavior is very annoying. Please fix this.