Comming from a gerrit background, I liked the fact that gerrit allowed you to mark a code review with a -1 or -2 (to block it). In stash you can approve a pull request to show that you agree with it but you can't mark the pull request as denied.
Declining a pull request is like abandonning a review in gerrit. I'd like to have a Deny button that you can toggle just so that it's easy to spot that a someone disaproves of your pull request.
Disaproving wouldn't block a pull request but it would be a great visual cue in the summary section to show that someone is protesting against your pull request (maybe put a little red mark in the avatar, akin to the green cross when someone approves).
Partially you can use Handbrake plugin for this.
https://bitbucket.org/Commander_Duck/stash-pull-request-handbrake
Thanks, it's not exactly what I'm looking for but I chose this one as the best answer because it inspired me to try to write a plugin to scratch my itch.
You must be a registered user to add a comment. If you've already registered, sign in. Otherwise, register and sign in.
Hi Fred,
As Robert pointed out we don't currently support this. I think there's definitely room for improvement of the pull request reviewer states - but we're being cautious about exactly how we implement it.
While this isn't exactly what you're asking for, you might want to vote on the following which I suspect from an implementation perspective would result in what you're asking for.
https://jira.atlassian.com/browse/STASH-2999
Otherwise feel free to create a new feature request so we can track specific interest.
Cheers,
Charles
You must be a registered user to add a comment. If you've already registered, sign in. Otherwise, register and sign in.
Unfortunately, no. You can approve or not approve, but you can't do a -1.
You must be a registered user to add a comment. If you've already registered, sign in. Otherwise, register and sign in.
Online forums and learning are now in one easy-to-use experience.
By continuing, you accept the updated Community Terms of Use and acknowledge the Privacy Policy. Your public name, photo, and achievements may be publicly visible and available in search engines.
You must be a registered user to add a comment. If you've already registered, sign in. Otherwise, register and sign in.