Is it possible to use Stash to review projects hosted on GitHub?

[BerislavLopac]

We have a bunch of projects hosted on GitHub, but we find GitHub's code review process sorely lacking. Is it possible to use Stash simply as a client tool to handle code reviews, using GitHub's pull requests, without setting the repos to be hosted with Stash? Thanks!

[TimP · Accepted solution]

Hi Berislav,

That isn't currently possible. However, you could consider hosting your code in Stash and using Stash's pull requests for code review, and mirroring to GitHub (using the free Repository Mirror plugin, for example). Out of curiosity, could you elaborate a little on what you like about Stash's code review process that you're missing in GitHub?

cheers,

Tim

[BerislavLopac]

Thank you for the answer! Well, to be honest, I haven't really worked with Stash yet, but have previously used Crucible extensively, and am missing it's power when it comes to code reviews. I'm currently exploring the tools for my team, and I wanted to test Stash as it seems to fit nicely into our process which is built around the concept of pull requests -- but due to the company policy our authoritative repos need to be hosted on GitHub. So I was hoping to use Stash as basically a client application to review pull requests on GitHub; barring that, I will most likely explore the possibility of using Crucible, which is less focused on pull requests but the other features are more important anyway.

[TimP]

Thanks for the insight Berislav! As you're probably aware, you can use Crucible to review code hosted in Stash, Bitbucket, GitHub or any other git host.

[BerislavLopac]

To be more specific, the main features that I miss on GitHub are file-per-file reviewing, explicit approval of the pull requests and historical comparison of individual commits. I don't know if Stash has all of those, but they help make Crucible so powerful.

[TimP]

Oh, great! Stash's Pull Requests have: - a file tree that allows you to individually review files (though all files on the branch are part of the PR, you can just view them one at a time) - explicit approval (and merge checks, which optionally prevent PRs from being merged until reviewers approve, CI builds pass, etc) - the ability to comment directly on a commit So it may work out for your requirements.

[TimP]

To clarify that last bullet point, Stash doesn't have the "commit sliders" that Crucible has to change the scope of a review, but it does have the ability to comment on individual commits outside of the context of a pull request. Anyhow, give it a try and let me know what you think :)

[BerislavLopac]

Thanks, I'll give a try to both Stash and Crucible with out environment and see how it works. Just one more question -- do I need a separate licence for FishEye in order to use Crucible with GitHub, or is Crucible enough by itself? Thanks!