Groovy Script Error Message

[Sinan Yesilyurt]

Hi,

I'm getting groovy records from SQL Table or Function. Example;

String subeKodu = get_sube_kodu_bul(matcher[0][1])

private String get_sube_kodu_bul(String subeAdi)
{
	def sql = Sql.newInstance("jdbc:jtds:sqlserver://10.xx.xx.xx:1433/DBNAME", "usrname","pass", "net.sourceforge.jtds.jdbc.Driver")
	subeAdi = subeAdi.trim()
	def row = sql.firstRow("SELECT TOP 1 SUBE_KODU FROM TABLENAME WHERE SUBE_ADI= '${subeAdi}'")
	if (row != null)
		return (String)row.SUBE_KODU
	else
		return ""
}

But  I am faced with the following error;

WARNING: In Groovy SQL please do not use quotes around dynamic expressions (which start with $) as this means we cannot use a JDBC PreparedStatement and so is a security hole. Groovy has worked around your mistake but the security hole is still there. The expression so far is: SELECT TOP 1 YETKILI FROM TABLENAME WHERE SUBE_ADI = '?'

Help please, thank you

[Sinan Yesilyurt · Accepted solution]

Connection change and solved.

[Alexey_Rjeutski__Polontech_]

Try the following:

def row = sql.firstRow("SELECT TOP 1 SUBE_KODU FROM TABLENAME WHERE SUBE_ADI= ?",[subeAdi])

[Sinan Yesilyurt]

Hi Alexey, the same error