Crash after startup

[Leo Wang]

Over 50% chance Sourcetree will crash after startup, both the release (3.3.8) and the beta version (3.4.4 beta1).

I loaded the dump file in WinDbg, here is the result.

It is a long standing bug. Please check. Thank you.

=================================

This dump file has an exception of interest stored in it.
The stored exception information can be accessed via .ecxr.
(154c.3488): CLR exception - code e0434352 (first/second chance not available)
For analysis of this file, run !analyze -v
ntdll!NtWaitForMultipleObjects+0x14:
00007ffa`7b9ed764 c3 ret
0:000> !analyze -v
*******************************************************************************
* *
* Exception Analysis *
* *
*******************************************************************************

*** WARNING: Unable to verify checksum for WindowsBase.ni.dll
*** WARNING: Unable to verify checksum for PresentationFramework.ni.dll
*** WARNING: Unable to verify checksum for System.Management.ni.dll
*** WARNING: Unable to verify checksum for System.ni.dll
DEBUG_FLR_EXCEPTION_CODE(80131509) and the ".exr -1" ExceptionCode(e0434352) don't match

KEY_VALUES_STRING: 1

Key : Analysis.CPU.Sec
Value: 41

Key : Analysis.DebugAnalysisProvider.CPP
Value: Create: 8007007e on LAPTOP-JHX1

Key : Analysis.DebugData
Value: CreateObject

Key : Analysis.DebugModel
Value: CreateObject

Key : Analysis.Elapsed.Sec
Value: 58

Key : Analysis.Memory.CommitPeak.Mb
Value: 262

Key : Analysis.System
Value: CreateObject

Key : CLR.Engine
Value: CLR

Key : CLR.System.InvalidOperationException._message
Value: This property has already been set and cannot be modified.

Key : CLR.System.Threading.Tasks.TaskSchedulerException._message
Value: An exception was thrown by a TaskScheduler.

Key : CLR.Version
Value: 4.0.30319.0

Key : Timeline.Process.Start.DeltaSec
Value: 8

NTGLOBALFLAG: 0

PROCESS_BAM_CURRENT_THROTTLED: 0

PROCESS_BAM_PREVIOUS_THROTTLED: 0

APPLICATION_VERIFIER_FLAGS: 0

CONTEXT: (.ecxr)
rax=00007ffa4d66fa6c rbx=00000000e0434352 rcx=00000000ffffffff
rdx=0000000000000000 rsi=0000000000000001 rdi=0000000000000005
rip=00007ffa79354b59 rsp=00000029b68fdea0 rbp=0000000000000000
r8=fffffffffffffffe r9=0000000000000001 r10=00007ffa4d69017c
r11=00000000ffffffff r12=0000000000004000 r13=000001fea8032780
r14=00000029b68fe038 r15=000001fea80321a0
iopl=0 nv up ei pl nz na pe nc
cs=0033 ss=002b ds=002b es=002b fs=0053 gs=002b efl=00000202
KERNELBASE!RaiseException+0x69:
00007ffa`79354b59 0f1f440000 nop dword ptr [rax+rax]
Resetting default scope

EXCEPTION_RECORD: (.exr -1)
ExceptionAddress: 00007ffa79354b59 (KERNELBASE!RaiseException+0x0000000000000069)
ExceptionCode: e0434352 (CLR exception)
ExceptionFlags: 00000001
NumberParameters: 5
Parameter[0]: ffffffff80131500
Parameter[1]: 0000000000000000
Parameter[2]: 0000000000000000
Parameter[3]: 0000000000000000
Parameter[4]: 00007ffa4d660000

PROCESS_NAME: SourceTree.exe

EXCEPTION_CODE_STR: 80131509

MISSING_CLR_SYMBOL: 0

FAULTING_THREAD: ffffffff

STACK_TEXT:
00000029`b7d7e730 00007ffa`4b8e9750 mscorlib_ni!System.Threading.Thread.set_Name+0xb0
00000029`b7d7e780 00007ff9`eee3c76d SourceTree_Api!SourceTree.Utils.PriorityScheduler.QueueTask+0x17d
00000029`b7d7e810 00007ffa`4b21a162 mscorlib_ni!System.Threading.Tasks.Task.ScheduleAndStart+0x222

SYMBOL_NAME: mscorlib_ni!System.Threading.Thread.set_Name+cc9750

MODULE_NAME: mscorlib

IMAGE_NAME: mscorlib.dll

STACK_COMMAND: !C:\ProgramData\dbg\sym\SOS_AMD64_AMD64_4.8.4341.00.dll\602301F3ac2000\SOS_AMD64_AMD64_4.8.4341.00.dll.pe 0x1fea774a858 ; ** Pseudo Context ** ManagedPseudo ** Value: 1a6d2751480 ** ; kb

FAILURE_BUCKET_ID: CLR_EXCEPTION_System.InvalidOperationException_80131509_mscorlib.dll!System.Threading.Thread.set_Name

BUCKET_ID_MODPRIVATE: 1

OS_VERSION: 10.0.19041.1

BUILDLAB_STR: vb_release

OSPLATFORM_TYPE: x64

OSNAME: Windows 10

FAILURE_ID_HASH: {068de35c-6a59-f4f4-dc33-c6d143854d9c}

Followup: MachineOwner
---------

[Greg Keogh]

Six months later, no change, no mention of the issue and it still crashes and crashes and crashes on startup.

Now that Visual Studio implements most of the functionality of SourceTree, I've been trying to migrate and remove all need for SourceTree so I can uninstall the damn thing and erase it from my mind. I think I'm about 90% of the way there. It's still quicker in SourceTree the click down a list of many files and browse their changes, but there's probably a replacement technique if I look hard enough.

[Greg Keogh]

Are you telling me that, two years after a crippling years-long bug is reported, it will be fixed in an upcoming release?! Good grief!

I uninstalled SourceTree in late 2021, after I complained about the bug and nothing happened and it kept crashing and crashing. By that time, Visual Studio had subsumed all commonly used source control features in a very convenient way, so as far as I'm concerned, SourceTree is dead to me and even thinking about it gives me a headache. It was a handy and quirky piece of free software that filled a gap for many years, but it's time is well over now.

[Mukesh Kumar]

Hi @Greg Keogh 

We have resolved the NullReferenceException from BookmarksPanelViewModel RefreshRepositorySummary in the stack. It will be available in Sourcetree 3.4.14 version soon.

[SmartPCUtilities]

I agree that VS has improved it's Git integration. In VS 2019 Ctrl + Alt + F7 will open a list of changed files, right click on the target file and can view its history, undo changes and view changes by clicking Compare with Unmodified

[SmartPCUtilities]

Still no fix for this annoying bug

System.NullReferenceException
at SourceTree.Utils.PriorityScheduler.QueueTask(System.Threading.Tasks.Task)
at System.Threading.Tasks.Task.ScheduleAndStart(Boolean)

[Greg Keogh]

Why is there no discussion of this really serious problem? I have been putting up with random startup crashes for more than a year. On average it takes me 4 or 5 attempts to launch SourceTree. The crash is always NullReferenceException just up from BookmarksPanelViewModel RefreshRepositorySummary in the stack.

This crash occurs on all of my Windows 10 machines and no amount of file or registry cleanups, or reinstalls or anything will make the slightest difference. It just crashes and crashes on startup, and it's been doing it for years.

Can someone do something about this please?

Greg