Thready 0.3.1 leads to problems with atlassian-spring-scanner

[Tobias Heinemann]

We have installed this Addons in Confluence 6.13.4:

• Thready 0.3.1
• Adaptavist ScriptRunner for Confluence 5.5.7
• ServiceRocket Tracking Plugin 4.4.1

2019-06-27 14:39:58,041 ERROR [ThreadPoolAsyncTaskExecutor::Thread 16] [extender.internal.support.ExtenderConfiguration] onOsgiApplicationEvent Application context refr
esh failed (NonValidatingOsgiBundleXmlApplicationContext(bundle=com.atlassian.plugins.graphql.atlassian-graphql-module, config=osgibundle:/META-INF/spring/*.xml))
org.springframework.beans.factory.BeanDefinitionStoreException: Unexpected exception parsing XML document from URL [bundle://289.0:0/META-INF/spring/atlassian-plugin-co
ntext.xml]; nested exception is java.lang.IllegalStateException: Cannot execute atlassian-spring-scanner-runtime: plugin has an extra copy of atlassian-spring-scanner-a
nnotation classes, perhaps embedded inside the target plugin 'com.atlassian.plugins.graphql.atlassian-graphql-module'; embedding scanner-annotations is not supported si
nce scanner version 2.0. Use 'mvn dependency:tree' and ensure the atlassian-spring-scanner-annotation dependency in your plugin has <scope>provided</scope>, not 'runtim
e' or 'compile', and you have NO dependency on atlassian-spring-scanner-runtime.
at org.springframework.beans.factory.xml.XmlBeanDefinitionReader.doLoadBeanDefinitions(XmlBeanDefinitionReader.java:414)
at org.springframework.beans.factory.xml.XmlBeanDefinitionReader.loadBeanDefinitions(XmlBeanDefinitionReader.java:336)
at org.springframework.beans.factory.xml.XmlBeanDefinitionReader.loadBeanDefinitions(XmlBeanDefinitionReader.java:304)
at org.springframework.beans.factory.support.AbstractBeanDefinitionReader.loadBeanDefinitions(AbstractBeanDefinitionReader.java:181)
at org.springframework.beans.factory.support.AbstractBeanDefinitionReader.loadBeanDefinitions(AbstractBeanDefinitionReader.java:217)
at org.springframework.beans.factory.support.AbstractBeanDefinitionReader.loadBeanDefinitions(AbstractBeanDefinitionReader.java:188)
[...]

Many addons, even system addons, fail to load during a restart of Confluence. Downgrading to Thready 0.2.1 resolves the problems.

[Andriy Yakovlev _Atlassian_ · Accepted solution]

@Tobias Heinemann 

Thanks for reporting the problem and sorry for inconveniences. 

I was able to reproduce the problem with Jira. 

I've built a new version of Thready 0.3.2 with updated spring scanner settings and uploaded to marketplace. 

Can pls also test it from your side, to make sure the problem is gone. 

[Tobias Heinemann]

Hello @Andriy Yakovlev _Atlassian_ ,

Thready works like a charm again. Thank you very much for resolving the problem that quickly.

Regards,

Tobias

[Thomas Weißschuh · Accepted solution]

The problem is the same as this: https://ecosystem.atlassian.net/browse/SCANNER-2170

The migration to spring scanner 2.0 should have also changed some configuration settings.

[Andriy Yakovlev _Atlassian_]

@Thomas Weißschuh 

Thanks, I will look into this.